brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #291: Conveniences to make groups easier to con...
Date Thu, 11 Aug 2016 19:44:43 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/291#discussion_r74489795
  
    --- Diff: camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/methods/BrooklynDslCommon.java
---
    @@ -327,25 +337,74 @@ public FormatString(String pattern, Object[] args) {
     
             private static final long serialVersionUID = 8878388748085419L;
     
    -        private String typeName;
    -        private Class<?> type;
    -        private Map<String,Object> fields, config;
    +        private final String typeName;
    +        private final String factoryMethodName;
    +        private final Class<?> type;
    +        private final List<Object> constructorArgs, factoryMethodArgs;
    +        private final Map<String, Object> fields, config;
    +
    +        public DslObject(
    +                String typeName,
    +                List<Object> constructorArgs,
    +                Map<String, Object> fields,
    +                Map<String, Object> config) {
    --- End diff --
    
    I'd use `Map<String, ?>` if we can get away with it - makes it easier for the caller.
    But this is pretty internal stuff, so I don't really care.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message