brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-server issue #292: Shared location customizer
Date Thu, 11 Aug 2016 19:34:03 GMT
Github user aledsage commented on the issue:

    https://github.com/apache/brooklyn-server/pull/292
  
    Thanks @duncangrant - finished reviewing.
    
    For the first commit, @bostko has incorporated those comments. I've created https://github.com/apache/brooklyn-server/pull/298
to get that merged asap (and I have added a few minor tweaks to that PR as well).
    
    For your `SharedLocationSecurityGroupCustomizer`, it looks good. a few very minor comments.
The only significant one is whether we add udp support as well. The reason I think it's worth
it now is that it will affect our naming: `portRanges` will be ambiguous if we add udp in
the future.
    
    If you want, you could just name it "tcpPortRanges" now, and defer adding udp. Up to you.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message