brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <>
Subject [GitHub] brooklyn-server pull request #292: Shared location customizer
Date Thu, 11 Aug 2016 18:45:53 GMT
Github user aledsage commented on a diff in the pull request:
    --- Diff: locations/jclouds/src/test/java/org/apache/brooklyn/location/jclouds/networking/
    @@ -0,0 +1,121 @@
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.brooklyn.location.jclouds.networking;
    +import static org.mockito.Matchers.any;
    +import static org.mockito.Mockito.*;
    +import static org.testng.Assert.assertEquals;
    +import java.util.List;
    +import org.apache.brooklyn.location.jclouds.JcloudsLocation;
    +import org.apache.brooklyn.location.jclouds.JcloudsMachineLocation;
    +import org.apache.brooklyn.util.collections.MutableMap;
    +import org.jclouds.compute.ComputeService;
    +import org.jclouds.compute.domain.Template;
    +import org.jclouds.compute.extensions.SecurityGroupExtension;
    +import org.jclouds.domain.Location;
    +import org.mockito.Answers;
    +import org.mockito.ArgumentCaptor;
    +import org.testng.annotations.BeforeMethod;
    +import org.testng.annotations.Test;
    +public class SharedLocationSecurityGroupCustomizerTest {
    +    TestSharedLocationSecurityGroupCustomizer customizer;
    +    JcloudsLocationSecurityGroupCustomizer sgCustomizer;
    +    ComputeService computeService;
    +    Location location;
    +    SecurityGroupExtension securityApi;
    +    private JcloudsLocation jcloudsLocation = new JcloudsLocation(MutableMap.of("deferConstruction",
    +    @BeforeMethod
    --- End diff --
    personal preference to always use `@BeforeMethod(alwaysRun=true)`. If someone later adds
(or marks) a test as `group="Integration"` then the setUp wouldn't run (but it would work
in the Eclipse IDE as that seems to always run the `@BeforeMethod` no matter what the test

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message