brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sjcorbett <...@git.apache.org>
Subject [GitHub] brooklyn-library pull request #57: add user sensor to MySqlNode
Date Fri, 05 Aug 2016 14:02:36 GMT
Github user sjcorbett commented on a diff in the pull request:

    https://github.com/apache/brooklyn-library/pull/57#discussion_r73696688
  
    --- Diff: software/database/src/main/java/org/apache/brooklyn/entity/database/mysql/MySqlNode.java
---
    @@ -89,6 +92,12 @@
     
         AttributeSensor<Double> QUERIES_PER_SECOND_FROM_MYSQL = Sensors.newDoubleSensor("mysql.queries.perSec.fromMysql");
     
    +    /** This comes from mysql.cnf
    +     * See http://dev.mysql.com/doc/refman/5.6/en/mysql-install-db.html and http://dev.mysql.com/doc/refman/5.7/en/mysql-install-db.html
    +     * for more details.
    +     * */
    +    String DEFAULT_USERNAME = "root";
    --- End diff --
    
    What's your reasoning for putting this on the interface vs. the implementation?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message