brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #285: [WIP] Adding HttpExecutor to be used for ...
Date Fri, 05 Aug 2016 10:47:02 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/285#discussion_r73674575
  
    --- Diff: utils/common/src/main/java/org/apache/brooklyn/util/http/HttpTool.java ---
    @@ -319,7 +318,7 @@ public HttpClientBuilder trustSelfSigned() {
                 return this;
             }
             public HttpClient build() {
    -            final DefaultHttpClient httpClient = new DefaultHttpClient(clientConnectionManager);
    +            final HttpExecutor httpClient = new HttpExecutorImpl(clientConnectionManager);
    --- End diff --
    
    I assumed we'd use the factory, rather than calling the constructor directly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message