brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #287: Add new member tracking policy with confi...
Date Fri, 05 Aug 2016 10:30:55 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/287#discussion_r73672833
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/entity/internal/EntityConfigMap.java
---
    @@ -132,7 +132,11 @@ public EntityConfigMap(AbstractEntity entity, Map<ConfigKey<?>,
Object> storage)
     
             // Get own value
             if (((ConfigKeySelfExtracting<T>)key).isSet(ownConfig)) {
    -            ownValue = Maybe.of(((ConfigKeySelfExtracting<T>)key).extractValue(ownConfig,
exec));
    +            Map<ConfigKey<?>, ?> ownCopy = null;
    --- End diff --
    
    Very minor: personal preference to not set its value to null when we're about to set its
value immediately below that. Let the compiler tell us if someone changing it makes a mistake
so the value no longer gets initialised.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message