Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B7F6D200B41 for ; Thu, 7 Jul 2016 20:16:28 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id B6AB1160A68; Thu, 7 Jul 2016 18:16:28 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 30DF9160A4F for ; Thu, 7 Jul 2016 20:16:28 +0200 (CEST) Received: (qmail 29228 invoked by uid 500); 7 Jul 2016 18:16:26 -0000 Mailing-List: contact dev-help@brooklyn.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@brooklyn.apache.org Delivered-To: mailing list dev@brooklyn.apache.org Received: (qmail 29217 invoked by uid 99); 7 Jul 2016 18:16:25 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 Jul 2016 18:16:25 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 51F59E03CE; Thu, 7 Jul 2016 18:16:25 +0000 (UTC) From: bostko To: dev@brooklyn.apache.org Reply-To: dev@brooklyn.apache.org Message-ID: Subject: [GitHub] brooklyn-library pull request #48: Fix NodeJsWebAppSshDriver to obtain prope... Content-Type: text/plain Date: Thu, 7 Jul 2016 18:16:25 +0000 (UTC) archived-at: Thu, 07 Jul 2016 18:16:28 -0000 GitHub user bostko opened a pull request: https://github.com/apache/brooklyn-library/pull/48 Fix NodeJsWebAppSshDriver to obtain properly MAIN_URL - make NodeJsWebAppSshDriver and JavaWebAppSshDriver to use a single method for obtaining the MAIN_URL This should be a standardized for all entities which has to have an option for exposing http MAIN_URL You can merge this pull request into a Git repository by running: $ git pull https://github.com/bostko/brooklyn-library accessible_web_url Alternatively you can review and apply these changes as the patch at: https://github.com/apache/brooklyn-library/pull/48.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #48 ---- commit 46925ba91a454049bff1a66f7caa759cd7c933e6 Author: Valentin Aitken Date: 2016-07-07T17:20:25Z Fix NodeJsWebAppSshDriver to obtain properly MAIN_URL - make NodeJsWebAppSshDriver and JavaWebAppSshDriver to use a single method for obtaining the MAIN_URL This should be a standardized for all entities which has to have an option for exposing http MAIN_URL ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---