Return-Path: <dev-return-17799-archive-asf-public=cust-asf.ponee.io@brooklyn.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 70571200B4F
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Tue, 26 Jul 2016 13:08:25 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 6F267160A56; Tue, 26 Jul 2016 11:08:25 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id B578B160A75
	for <archive-asf-public@cust-asf.ponee.io>; Tue, 26 Jul 2016 13:08:24 +0200 (CEST)
Received: (qmail 69106 invoked by uid 500); 26 Jul 2016 11:08:23 -0000
Mailing-List: contact dev-help@brooklyn.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@brooklyn.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@brooklyn.apache.org>
List-Post: <mailto:dev@brooklyn.apache.org>
List-Id: <dev.brooklyn.apache.org>
Reply-To: dev@brooklyn.apache.org
Delivered-To: mailing list dev@brooklyn.apache.org
Received: (qmail 68995 invoked by uid 99); 26 Jul 2016 11:08:23 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Jul 2016 11:08:23 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 861F9E08E8; Tue, 26 Jul 2016 11:08:23 +0000 (UTC)
From: geomacy <git@git.apache.org>
To: dev@brooklyn.apache.org
Reply-To: dev@brooklyn.apache.org
References: <git-pr-53-brooklyn-library@git.apache.org>
In-Reply-To: <git-pr-53-brooklyn-library@git.apache.org>
Subject: [GitHub] brooklyn-library pull request #53: Do not merge, for review: Move karaf dist...
Content-Type: text/plain
Message-Id: <20160726110823.861F9E08E8@git1-us-west.apache.org>
Date: Tue, 26 Jul 2016 11:08:23 +0000 (UTC)
archived-at: Tue, 26 Jul 2016 11:08:25 -0000

Github user geomacy commented on a diff in the pull request:

    https://github.com/apache/brooklyn-library/pull/53#discussion_r72228679
  
    --- Diff: karaf/features/pom.xml ---
    @@ -0,0 +1,60 @@
    +<?xml version="1.0" encoding="UTF-8"?>
    +<!--
    +    Licensed to the Apache Software Foundation (ASF) under one
    +    or more contributor license agreements.  See the NOTICE file
    +    distributed with this work for additional information
    +    regarding copyright ownership.  The ASF licenses this file
    +    to you under the Apache License, Version 2.0 (the
    +    "License"); you may not use this file except in compliance
    +    with the License.  You may obtain a copy of the License at
    +
    +     http://www.apache.org/licenses/LICENSE-2.0
    +
    +    Unless required by applicable law or agreed to in writing,
    +    software distributed under the License is distributed on an
    +    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +    KIND, either express or implied.  See the License for the
    +    specific language governing permissions and limitations
    +    under the License.
    +-->
    +<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
    +         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
    +
    +    <modelVersion>4.0.0</modelVersion>
    +    <parent>
    +        <groupId>org.apache.brooklyn</groupId>
    +        <artifactId>brooklyn-library-karaf</artifactId>
    +        <version>0.10.0-SNAPSHOT</version>  <!-- BROOKLYN_VERSION -->
    +    </parent>
    +
    +    <artifactId>brooklyn-library-features</artifactId>
    +    <name>Brooklyn Library Karaf Features</name>
    +    <description>Defines Karaf features for Karaf runtime</description>
    +    <packaging>feature</packaging>
    +
    +    <build>
    +        <pluginManagement>
    +            <plugins>
    +                <plugin>
    +                    <groupId>org.apache.karaf.tooling</groupId>
    +                    <artifactId>karaf-maven-plugin</artifactId>
    +                    <version>4.0.1</version>
    +                    <extensions>true</extensions>
    +                </plugin>
    +            </plugins>
    +        </pluginManagement>
    +        <plugins>
    +            <plugin>
    +                <groupId>org.apache.karaf.tooling</groupId>
    +                <artifactId>karaf-maven-plugin</artifactId>
    +
    +                <configuration>
    +                    <startLevel>50</startLevel>
    --- End diff --
    
    It's a good question - I copied this as-is from brooklyn-server/karaf/features, where it was introduced by https://github.com/apache/brooklyn-server/commit/4b1ede22489e18605829d91b4af6eb2a0c41645d, but it isn't obvious to me that this would be necessary.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---