brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BROOKLYN-315) catalog .bom parsing should support `deprecated: true`
Date Tue, 12 Jul 2016 11:32:20 GMT

    [ https://issues.apache.org/jira/browse/BROOKLYN-315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15372731#comment-15372731
] 

ASF GitHub Bot commented on BROOKLYN-315:
-----------------------------------------

Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/241#discussion_r70421064
  
    --- Diff: karaf/init/src/main/resources/catalog-classes.bom ---
    @@ -505,3 +505,36 @@ brooklyn.catalog:
             type: org.apache.brooklyn.entity.cm.ansible.AnsibleEntity
             name: AnsibleEntity
             description: Software managed by Ansible CM
    +
    +  - brooklyn.libraries:
    +    - name: org.apache.brooklyn.brooklyn-test-framework
    +      version: "0.10.0.SNAPSHOT" # BROOKLYN_VERSION
    +    itemType: entity
    +    items:
    +    - id: org.apache.brooklyn.test.framework.TestSshCommand
    +      item:
    +        type: org.apache.brooklyn.test.framework.TestSshCommand
    +    - id: org.apache.brooklyn.test.framework.SimpleShellCommandTest
    --- End diff --
    
    Good question. That depends on what backwards compatibility we want. I think we want to
minimise the amount of breakage when someone is upgrading so probably include it. But we want
to hide it so folk aren't offered it.
    
    We have a `CatalogItem.setDeprecated`. We should probably change our yaml parser to accept
`deprecated: true`, and to set that on the catalog item. But not in this PR. See https://issues.apache.org/jira/browse/BROOKLYN-315


> catalog .bom parsing should support `deprecated: true`
> ------------------------------------------------------
>
>                 Key: BROOKLYN-315
>                 URL: https://issues.apache.org/jira/browse/BROOKLYN-315
>             Project: Brooklyn
>          Issue Type: Improvement
>    Affects Versions: 0.9.0
>            Reporter: Aled Sage
>
> I want to add deprecated items to the catalog via a yaml .bom. Under the covers, we have
{{CatalogItem.setDeprecated()}}. We can add support in the yaml parser to accept `deprecated:
true`, and to set that on the catalog item. 
> See https://github.com/apache/brooklyn-server/pull/241 for an example of where we'd use
this. My specific use-case is the catalog items declared for use in Karaf. We have the deprecated
entity type {{org.apache.brooklyn.test.framework.SimpleShellCommandTest}}, which was renamed
to {{org.apache.brooklyn.test.framework.TestSshCommand}}. We should add the former to the
catalog so that existing blueprints work. But by marking it deprecated, we would be able to
hide it from UI drop-downs etc.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message