brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From grkvlt <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #279: Allow provisioning.properties to referenc...
Date Sat, 30 Jul 2016 13:57:19 GMT
Github user grkvlt commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/279#discussion_r72888151
  
    --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java
---
    @@ -527,7 +531,7 @@ public ComputeService getComputeService(Map<?,?> flags) {
     
         public ComputeService getComputeService(ConfigBag config) {
             ComputeServiceRegistry registry = getConfig(COMPUTE_SERVICE_REGISTRY);
    -        return registry.findComputeService(ResolvingConfigBag.newInstanceExtending(getManagementContext(),
config), true);
    --- End diff --
    
    By the time `getComputeService()` is called, I will already have set up the `ConfigBag`
to be a resolving config, see `private ConfigBag getConfigBag(Map<?, ?> flags)` method
below. The addition of a new `ResolvingConfigBag` was redundant. In essence I'm solving the
same problem as **BROOKLYN-249** and also adding the ability to resolve config through the
calling entity context, if it exists.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message