brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #281: Prevent VanillaSoftwareProcess commands f...
Date Fri, 29 Jul 2016 19:35:39 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/281#discussion_r72848780
  
    --- Diff: software/base/src/main/java/org/apache/brooklyn/entity/software/base/SoftwareProcess.java
---
    @@ -241,6 +246,7 @@
         @SetFromFlag("runtimeTemplates")
         MapConfigKey<String> RUNTIME_TEMPLATES = new MapConfigKey.Builder<String>(String.class,
"templates.runtime")
                 .description("Mapping of templates, to be filled in and copied before customisation,
to destination name relative to runDir") 
    +            .parentInheritance(ConfigInheritance.NONE)
    --- End diff --
    
    Not sure about the file uploads. I suggest to leave them as is. The worst that can happen
is to end up with some unused files on the machine. I'd even go as far as changing to merge
behaviour :).
    +1 for the rest.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message