brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-server issue #277: Fix TestCases, and add TestSensor.abortCondition...
Date Fri, 29 Jul 2016 17:03:30 GMT
Github user aledsage commented on the issue:

    https://github.com/apache/brooklyn-server/pull/277
  
    To clarify what I meant by "validConditions sounds like it could be a valid termination
condition"...
    
    I mean that if someone is writing a test-case or is reading someone else's test-case,
then "validConditions" might seem like it could be used as the condition that must be satisfied
for the test to complete. So they might try to use that rather than "assertions". But I'm
sure we can avoid that with suitable config descriptions. And I can't think of a better name
than "validConditions" (without getting ridiculously technical like "validTransientConditions"
or some such).
    
    ---
    Build was previously failing because I'd missed the `AbortError.java` file from my commits!
Fixed that now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message