brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #266: BROOKLYN-264: refactor wait-for-provision
Date Tue, 19 Jul 2016 10:56:12 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/266#discussion_r71316462
  
    --- Diff: software/base/src/main/java/org/apache/brooklyn/entity/software/base/lifecycle/MachineLifecycleEffectorTasks.java
---
    @@ -444,9 +493,6 @@ public void run() {
                     }
                 }
                 entity().addLocations(ImmutableList.of((Location) machine));
    -            if (entity().getAttribute(Attributes.JCLOUDS_PROVISIONING_RUNNING) != null)
{
    --- End diff --
    
    One big reason that someone might call stop() while it's still starting is they realise
their provisioning parameters were wrong, so want to abort. Therefore continuing to support
that use-case seems important.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message