brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #256: Convert versions to OSGi format before pa...
Date Wed, 13 Jul 2016 15:53:54 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/256#discussion_r70653631
  
    --- Diff: utils/common/src/main/java/org/apache/brooklyn/util/osgi/OsgiUtils.java ---
    @@ -98,4 +101,97 @@ public static String getVersionedId(Bundle b) {
             return Maybe.of(new VersionedName(parts[0], v));
         }
     
    +    public static String toOsgiVersion(String version) {
    --- End diff --
    
    Worth adding a test that demonstrates the behaviour (even though the code is copy-pasted).
I'd also like to see that a version such as `0.10.0-20160713.1653` is converted to `0.10.0.20160713_1653`.
Note the last dot is converted to an underscore.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message