brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-library pull request #44: RiakNode Internal Networking
Date Tue, 12 Jul 2016 12:48:26 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-library/pull/44#discussion_r70430508
  
    --- Diff: software/nosql/src/main/java/org/apache/brooklyn/entity/nosql/riak/RiakNode.java
---
    @@ -125,14 +125,28 @@
     
         AttributeSensor<String> RIAK_NODE_NAME = Sensors.newStringSensor("riak.node",
"Returns the riak node name as defined in vm.args");
     
    -    // these needed for nodes to talk to each other, but not clients (so ideally set
up in the security group for internal access)
    -    PortAttributeSensorAndConfigKey HANDOFF_LISTENER_PORT = new PortAttributeSensorAndConfigKey("handoffListenerPort",
"Handoff Listener Port", "8099+");
    -    PortAttributeSensorAndConfigKey EPMD_LISTENER_PORT = new PortAttributeSensorAndConfigKey("epmdListenerPort",
"Erlang Port Mapper Daemon Listener Port", "4369");
    -    PortAttributeSensorAndConfigKey ERLANG_PORT_RANGE_START = new PortAttributeSensorAndConfigKey("erlangPortRangeStart",
"Erlang Port Range Start", "6000+");
    -    PortAttributeSensorAndConfigKey ERLANG_PORT_RANGE_END = new PortAttributeSensorAndConfigKey("erlangPortRangeEnd",
"Erlang Port Range End", "7999+");
    +    /*
    +     * Needed for nodes to talk to each other, but not clients, so ideally set up in
the security group for internal access and configured here.
    +     * If {@link #CONFIGURE_INTERNAL_NETWORKING} is set, then a location customizer will
be added to confiure the security group dynamically.
    +     */
    +
    +    @SetFromFlag("handoffListenerPort")
    +    ConfigKey<Integer> HANDOFF_LISTENER_PORT = ConfigKeys.newIntegerConfigKey("riak.handoff.port",
"Handoff Listener Port", 8099);
    --- End diff --
    
    @neykov are you sure? I thought `ConfigToAttributes.apply(Entity)` would get called, which
would do this for anything of type `AttributeSensorAndConfigKey`. But I haven't tested this
recently.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message