brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-library pull request #44: RiakNode Internal Networking
Date Tue, 12 Jul 2016 12:47:49 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-library/pull/44#discussion_r70430213
  
    --- Diff: software/nosql/src/main/java/org/apache/brooklyn/entity/nosql/riak/RiakNode.java
---
    @@ -107,10 +107,10 @@
     
         // NB these two needed for clients to access
         @SetFromFlag("riakWebPort")
    -    PortAttributeSensorAndConfigKey RIAK_WEB_PORT = new PortAttributeSensorAndConfigKey("riak.webPort",
"Riak Web Port", "8098+");
    +    PortAttributeSensorAndConfigKey RIAK_WEB_PORT = ConfigKeys.newPortSensorAndConfigKey("riak.web.port",
"Riak Web Port", "8098+");
    --- End diff --
    
    I'd be very cautious: I'd create a second config key with the old name, and fallback to
that. And I'd make sure a sensor with the old name is published.
    
    Looking at some customer bespoke code, they depend on "riak.pbPort" and "riak.webPort"
being published as sensors (for their enricher that propagates the public endpoint). We can
tell them to change this, but we should not break backwards compatibility lightly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message