brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #241: catalog-classes.bom: adds brooklyn-test-f...
Date Tue, 12 Jul 2016 11:31:35 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/241#discussion_r70421064
  
    --- Diff: karaf/init/src/main/resources/catalog-classes.bom ---
    @@ -505,3 +505,36 @@ brooklyn.catalog:
             type: org.apache.brooklyn.entity.cm.ansible.AnsibleEntity
             name: AnsibleEntity
             description: Software managed by Ansible CM
    +
    +  - brooklyn.libraries:
    +    - name: org.apache.brooklyn.brooklyn-test-framework
    +      version: "0.10.0.SNAPSHOT" # BROOKLYN_VERSION
    +    itemType: entity
    +    items:
    +    - id: org.apache.brooklyn.test.framework.TestSshCommand
    +      item:
    +        type: org.apache.brooklyn.test.framework.TestSshCommand
    +    - id: org.apache.brooklyn.test.framework.SimpleShellCommandTest
    --- End diff --
    
    Good question. That depends on what backwards compatibility we want. I think we want to
minimise the amount of breakage when someone is upgrading so probably include it. But we want
to hide it so folk aren't offered it.
    
    We have a `CatalogItem.setDeprecated`. We should probably change our yaml parser to accept
`deprecated: true`, and to set that on the catalog item. But not in this PR. See https://issues.apache.org/jira/browse/BROOKLYN-315


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message