brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-server issue #240: Use entity's classpath when loading resources
Date Fri, 08 Jul 2016 23:50:26 GMT
Github user aledsage commented on the issue:

    https://github.com/apache/brooklyn-server/pull/240
  
    @neykov I'm not sure what the best thing to do is here long term. You could imagine having
a catalog item X that has library L, which includes an inner entity from another catalog item
Y. And that in X, it sets a config value on the inner entity (where the type of the value
is a class in L, e.g. using `$brooklyn:object`). On rebind, for us to fully deserialize the
file for the inner entity, it will need access to library L. If we changed the catalog reference
so that the inner entity knew only about Y and not X, then it wouldn't have access to L.
    
    We could let it have the chain of catalog items. But that might lead to conflicting dependencies.
    
    Much longer term, we probably want to encourage state to be simple - primitives/strings/maps
etc wherever possible.
    
    I'm happy to merge this now. Except for the failing jenkins test ({{org.apache.brooklyn.AssemblyTest.checkBrooklynCoreFeature}}).
Any ideas how we fix that? It has failed in a couple of different PR builds.
    
    I'll leave you to merge this when you're happy with it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message