brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-server issue #226: Expose assertServiceFailed(Entity) and assertSer...
Date Mon, 04 Jul 2016 13:01:26 GMT
Github user aledsage commented on the issue:

    https://github.com/apache/brooklyn-server/pull/226
  
    @bostko I'm unsure about this. The problem is whether `assertServiceFailed` and `assertServiceHealthy`
are general enough for all entities. The name "service" also looks out of place, compared
to the other methods (but I do see that it agrees with the name in "SERVICE_UP").
    
    At the very least, we'd need clear javadoc to say what is being asserted. And probably
should mark it `@Beta`.
    
    I suspect there are a lot of places in our code that we do this pair of assertions, so
overall I do lean towards including it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message