brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <>
Subject [GitHub] brooklyn-server pull request #226: Expose assertServiceFailed(Entity) and as...
Date Mon, 04 Jul 2016 12:55:41 GMT
Github user aledsage commented on a diff in the pull request:
    --- Diff: core/src/main/java/org/apache/brooklyn/core/entity/ ---
    @@ -223,4 +225,14 @@ public void run() {
    +    public static void assertServiceFailed(Entity test) {
    +        assertFalse(test.sensors().get(SERVICE_UP), "Service should be down");
    +        assertEquals(ServiceStateLogic.getExpectedState(test), Lifecycle.ON_FIRE, "Service
should be marked on fire");
    --- End diff --
    Why is this using `getExpectedState`, rather than `assertAttributeEquals(test, Attributes.SERVICE_STATE_ACTUAL,

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message