brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robertgmoss <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #218: Yaml entity refs: support $brooklyn:self(...
Date Mon, 04 Jul 2016 10:58:14 GMT
Github user robertgmoss commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/218#discussion_r69441669
  
    --- Diff: launcher/src/test/java/org/apache/brooklyn/launcher/blueprints/Windows7zipBlueprintLiveTest.java
---
    @@ -81,7 +81,7 @@ public void test7zip() throws Exception {
             
             Predicate<Application> asserter = new Predicate<Application>() {
                 @Override public boolean apply(Application app) {
    -                VanillaWindowsProcess entity = Iterables.getOnlyElement(Entities.descendants(app,
VanillaWindowsProcess.class));
    +                VanillaWindowsProcess entity = Iterables.getOnlyElement(Entities.descendantsAndSelf(app,
VanillaWindowsProcess.class));
    --- End diff --
    
    The author of this test clearly only wanted self here - is it worth adding a self method
to `Entities`? (or if this comes up a lot a `rootElement()` method on Application? - not necessary
for this PR)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message