brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #225: Improve test cases
Date Mon, 04 Jul 2016 10:46:16 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/225#discussion_r69440408
  
    --- Diff: test-framework/src/test/java/org/apache/brooklyn/test/framework/TestSshCommandTest.java
---
    @@ -278,6 +274,28 @@ public void shouldFailIfTestEntityHasNoMachine() throws Exception
{
         }
         
         @Test
    +    public void shouldFailFastIfNoCommand() throws Exception {
    +        Map<String, ?> equalsZero = ImmutableMap.of(EQUALS, 0);
    +        
    +        TestSshCommand test = app.createAndManageChild(EntitySpec.create(TestSshCommand.class)
    +                .configure(TIMEOUT, Duration.ONE_MINUTE)
    --- End diff --
    
    We've seen on apache jenkins that tests some times run extremely slowly (possibly due
to thread starvation). I'm not sure we've ever reached 10 seconds, but certainly several seconds.
Our general default timeout is 30 seconds in `Asserts.DEFAULT_LONG_TIMEOUT`, given these are
not performance tests.
    
    The reason I put it as one minute here is that if the fail-fast doesn't happen, then the
existing default is 30 seconds. I don't want us to pass the test with a false-positive when
it was really just a slow timeout, and the defaults being applied. But I also feel like leaving
the "normal" default time in the assertion a few lines lower down. I could/should have referenced
that constant rather than re-declaring 30 seconds again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message