Mailing-List: contact dev-help@brooklyn.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.apache.org
From: ahgittin <git@git.apache.org>
To: dev@brooklyn.apache.org
Reply-To: dev@brooklyn.apache.org
Message-ID: <git-pr-221-brooklyn-server@git.apache.org>
Subject: [GitHub] brooklyn-server pull request #221: Misc cleanup of javalang, type coercion, ...
Content-Type: text/plain
Date: Sun, 26 Jun 2016 21:02:11 +0000 (UTC)
archived-at: Sun, 26 Jun 2016 21:02:13 -0000

GitHub user ahgittin opened a pull request:

    https://github.com/apache/brooklyn-server/pull/221

    Misc cleanup of javalang, type coercion, jsonya, and Maybe

    big tidy is https://github.com/apache/brooklyn-server/commit/ec4da197d5caf3ac9bb63ab94924718aae83c615 moving most of our static `TypeCoercions` to a non-static `utils` impl (but not changing how we use `TypeCoercions` ... apart from the exception it throws)
    
    others are as described in the individual commits, nothing too exciting, and big improvements to tests and javadocs
    
    encountered while looking at how we can improve yaml type inference

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ahgittin/brooklyn-server misc-cleanup-javalang-and-type-coercion

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/221.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #221
    
----
commit 1f973df594cd359d1ad04c52c4f003d18191b339
Author: Alex Heneveld <alex.heneveld@cloudsoftcorp.com>
Date:   2016-06-24T09:58:38Z

    Maybe gives more control over the exceptions it throws
    
    You can do `orThrowingUnwrapped()` to suppress the add'l caller trace,
    and you can change more easily change the type of the exception it will throw.

commit 785342a4aebe0af47fac1e44205f85c28d320f79
Author: Alex Heneveld <alex.heneveld@cloudsoftcorp.com>
Date:   2016-06-24T21:48:10Z

    Maybe offers more clarity around whether it creates an exception on Absent
    
    and has a toOptional, and tests

commit 864400306d0433e26a51e96639de2d2b08b9bc4f
Author: Alex Heneveld <alex.heneveld@cloudsoftcorp.com>
Date:   2016-06-24T10:00:14Z

    Jsonya allows primitives and lists at the root now
    
    bringing it in line with json which has always allowed lists and now allows primitives, as root objects

commit ec4da197d5caf3ac9bb63ab94924718aae83c615
Author: Alex Heneveld <alex.heneveld@cloudsoftcorp.com>
Date:   2016-06-24T10:02:52Z

    refactor TypeCoercions so that most is in utils with an interface
    
    with the Brooklyn TypeCoercions referring to and extending that

commit 23ab1c506bdda9a3ac79199146ea9750d18d9005
Author: Alex Heneveld <alex.heneveld@cloudsoftcorp.com>
Date:   2016-06-24T10:13:18Z

    tidy/enhancements to javalang utils
    
    a few more methods which were elsewhere or not present,
    better methods using Maybe, and callers updated to use them

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---