Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E622B200B27 for ; Wed, 22 Jun 2016 17:48:59 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id E47D9160A24; Wed, 22 Jun 2016 15:48:59 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 5D55A160A6A for ; Wed, 22 Jun 2016 17:48:59 +0200 (CEST) Received: (qmail 20554 invoked by uid 500); 22 Jun 2016 15:48:58 -0000 Mailing-List: contact dev-help@brooklyn.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@brooklyn.apache.org Delivered-To: mailing list dev@brooklyn.apache.org Received: (qmail 20132 invoked by uid 99); 22 Jun 2016 15:48:58 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Jun 2016 15:48:58 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 14330DFEDA; Wed, 22 Jun 2016 15:48:58 +0000 (UTC) From: aledsage To: dev@brooklyn.apache.org Reply-To: dev@brooklyn.apache.org Message-ID: Subject: [GitHub] brooklyn-server pull request #214: BROOKLYN-305: handle invalid xml chars in... Content-Type: text/plain Date: Wed, 22 Jun 2016 15:48:58 +0000 (UTC) archived-at: Wed, 22 Jun 2016 15:49:00 -0000 GitHub user aledsage opened a pull request: https://github.com/apache/brooklyn-server/pull/214 BROOKLYN-305: handle invalid xml chars in attribute vals I'm not convinced by this approach (calling a special method `XmlUtil.xpathHandlingIllegalChars()`, which retries the xpath having escaped the illegal characters). It works well enough for us because we are just making very basic use of xpath - it is primarily to just extact the entity id from the xml file, before we try to fully deserialize it. You can merge this pull request into a Git repository by running: $ git pull https://github.com/aledsage/brooklyn-server fix/xml-deserialize-illegal-chars Alternatively you can review and apply these changes as the patch at: https://github.com/apache/brooklyn-server/pull/214.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #214 ---- commit e15697f42eb103fb393ab391f53bcd1d7ebd4d38 Author: Aled Sage Date: 2016-06-22T12:24:01Z Improve/test performance of XmlUtil.xpath commit 7981326612d20a0d6bd9b7d972620f5e2e0b4fc3 Author: Aled Sage Date: 2016-06-22T12:24:30Z Adds XmlSerializerTest commit 17d496a9d73f2079349ba01cc8f296fa303efc40 Author: Aled Sage Date: 2016-06-22T14:09:02Z BROOKLYN-305: Handle invalid xml chars in attribute vals ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---