Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 97C9A200ACA for ; Thu, 9 Jun 2016 17:57:36 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 96676160A58; Thu, 9 Jun 2016 15:57:36 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 10E5B160A29 for ; Thu, 9 Jun 2016 17:57:35 +0200 (CEST) Received: (qmail 29612 invoked by uid 500); 9 Jun 2016 15:57:35 -0000 Mailing-List: contact dev-help@brooklyn.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@brooklyn.apache.org Delivered-To: mailing list dev@brooklyn.apache.org Received: (qmail 29601 invoked by uid 99); 9 Jun 2016 15:57:34 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Jun 2016 15:57:34 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id CDFE8DFC71; Thu, 9 Jun 2016 15:57:34 +0000 (UTC) From: aledsage To: dev@brooklyn.apache.org Reply-To: dev@brooklyn.apache.org Message-ID: Subject: [GitHub] brooklyn-server pull request #192: Adds OnSubnetNetworkEnricher Content-Type: text/plain Date: Thu, 9 Jun 2016 15:57:34 +0000 (UTC) archived-at: Thu, 09 Jun 2016 15:57:36 -0000 GitHub user aledsage opened a pull request: https://github.com/apache/brooklyn-server/pull/192 Adds OnSubnetNetworkEnricher Some entities publish their endpoint using the public hostname (e.g. `MySqlNode` publishes `datastore.url` using the sensor `host.name`). If trying to connect to it from within the same subnet, this can fail if the public ip/hostname is not accessible. This topic is covered in the "Working with Multiple Networks" proposal (see dev@brooklyn email thread). That suggests we should use the subnet address in things like the datastore.url. That will likely break things for some of our users. But while we discuss/finalise that proposal... This enricher allows one to publish another sensor that definitely uses the subnet address. It will publish the sensor as things like `datastore.url.mapping.subnet`. This is really a temporary solution (hence marking this as `@Beta`). You can merge this pull request into a Git repository by running: $ git pull https://github.com/aledsage/brooklyn-server OnSubnetNetworkEnricher Alternatively you can review and apply these changes as the patch at: https://github.com/apache/brooklyn-server/pull/192.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #192 ---- commit 1660790c9c98b9993631f9107dd1c10c570de420 Author: Aled Sage Date: 2016-06-09T15:49:48Z Adds OnSubnetNetworkEnricher ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---