Mailing-List: contact dev-help@brooklyn.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.apache.org
Subject: Re: Disable non-deterministic failing unit tests, while fixing them
 [BROOKLYN-272] <-- BROOKLYN-291
To: dev@brooklyn.apache.org
References: <93953c63-3fb5-8732-f48b-72ce95262dad@gmail.com>
 <CAH20XTbAsa4Q=4cHc16xTMODHOtHJUmAGAmnoabG0nbNydFK6g@mail.gmail.com>
 <2683b91f-ddb0-39d8-ff59-54b7c02bdd66@gmail.com>
 <CAH20XTZZpTdh6Y-2d=C2i_N9wzKukjU+hDtTLT7ZKViF1ET-pw@mail.gmail.com>
From: Aled Sage <aled.sage@gmail.com>
Message-ID: <ad6a73d4-e960-7735-2c55-a37d59032da2@gmail.com>
Date: Tue, 7 Jun 2016 23:55:47 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0)
 Gecko/20100101 Thunderbird/45.1.1
MIME-Version: 1.0
In-Reply-To: <CAH20XTZZpTdh6Y-2d=C2i_N9wzKukjU+hDtTLT7ZKViF1ET-pw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
archived-at: Tue, 07 Jun 2016 22:55:50 -0000

Hi all,

TL;DR we hopefully have a fix for what might have caused many tests to 
fail non-deterministically. Please review.

Having investigated a few non-deterministic tests, I think I've finally 
got to the bottom of what might be causing some/many of them to fail.

I've raised a Jira and a PR that describe and fix the problem:
     https://issues.apache.org/jira/browse/BROOKLYN-291
     https://github.com/apache/brooklyn-server/pull/187

I'd appreciate a careful review. It only changes a few lines of code, 
but it's quite deep in Brooklyn so might have unforeseen consequences.

---
If this is the right fix, then we should look at (selectively) 
re-enabling the tests we marked as "Broken".

Aled