Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id C225F200AC8 for ; Tue, 7 Jun 2016 11:50:23 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id C098E160A36; Tue, 7 Jun 2016 09:50:23 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 14E75160A35 for ; Tue, 7 Jun 2016 11:50:22 +0200 (CEST) Received: (qmail 17964 invoked by uid 500); 7 Jun 2016 09:50:22 -0000 Mailing-List: contact dev-help@brooklyn.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@brooklyn.apache.org Delivered-To: mailing list dev@brooklyn.apache.org Received: (qmail 17940 invoked by uid 99); 7 Jun 2016 09:50:16 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Jun 2016 09:50:16 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 8EA211A10B6 for ; Tue, 7 Jun 2016 09:50:16 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.179 X-Spam-Level: * X-Spam-Status: No, score=1.179 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd2-us-west.apache.org (amavisd-new); dkim=pass (1024-bit key) header.d=cloudsoftcorp.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id vLMt4_sCr05I for ; Tue, 7 Jun 2016 09:50:14 +0000 (UTC) Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 924775FB36 for ; Tue, 7 Jun 2016 09:50:13 +0000 (UTC) Received: by mail-wm0-f41.google.com with SMTP id k204so61068590wmk.0 for ; Tue, 07 Jun 2016 02:50:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudsoftcorp.com; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=cQxLKwctRXXoi6DKwnnTvt81yN5oONiCHBQk56qAW7Y=; b=ZRkmmByvLniNg0GnoMPMgML2PPUeBUA4uhSQVyUT4poHGpAem1xXtYwG2DwSM1igm3 CCWJqvF/EK2eO41dT7uTszJkl4J7MWMSJX5rETg7zn95+hqreUL2OW3tbmCpzenXeSy1 zYNipzeCJVJlfTXpY2Z3uYenLcb1kdfKnHl3Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=cQxLKwctRXXoi6DKwnnTvt81yN5oONiCHBQk56qAW7Y=; b=meqtDAyEORJCKT6mV190G50phiFAvqxGsrIKcqh78HIT2qnCdkGtKOMhLI0QdvR6oZ ymzbtoystA6K5rMYIkd3uw8JUB1yOAMgyIkRnHAiBfBVvtPPp6kcLo2xhVXv1ZoihYoM BXMeXmBAvOOOpNMPhfJ7C60foQ+QEUla+Wv4MSjlnSjYZnApsbEAvAT9VBc3E98E4+dm D191bzfaS32MtM4j4Uwj6sfT9vmRWVsZC7yWXvt4VUuDppiAb1L12gNqZPT9wJJFIpIa tviShNzdg3FtZCsWm1q5fo43e2gUP80dAXV+CEYzrBTBnjneJlSntlw1yVvyrFjM8TlJ 2D/A== X-Gm-Message-State: ALyK8tJPinNmrn+12NslsvzRx1yRE9lI1XWBJBnLfXVUatMqa52WNHPv9aOxsXxhVD5E1tsLz9GYQA5Cc4or6tltkaq7bJJEEeV8GIhBRb8dVzi7Ho+DQZlqVp13LZPiJ4e4adJh+du/8kF4ymv25A== X-Received: by 10.194.20.39 with SMTP id k7mr22944734wje.133.1465293013245; Tue, 07 Jun 2016 02:50:13 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.30.197 with HTTP; Tue, 7 Jun 2016 02:49:43 -0700 (PDT) In-Reply-To: <91AC3A89-419E-4E13-AF67-148FC41B4092@cloudsoftcorp.com> References: <1182870d-0e3b-268a-e4df-b9ab6ea1d7fa@gmail.com> <91AC3A89-419E-4E13-AF67-148FC41B4092@cloudsoftcorp.com> From: Graeme Miller Date: Tue, 7 Jun 2016 10:49:43 +0100 Message-ID: Subject: Re: [PROPOSAL] Rename SimpleShellCommandTest to TestSshCommand To: dev@brooklyn.apache.org Content-Type: multipart/alternative; boundary=047d7b5d441e8c03060534ad1d98 X-Legal-Virus-Advice: Whilst all reasonable care has been taken to avoid the transmission of viruses, it is the responsibility of the recipient to ensure that the onward transmission, opening or use of this message and any attachments will not adversely affect its systems or data. No responsibility is accepted by Cloudsoft Corporation Limited in this regard and the recipient should carry out such virus and other checks as it considers appropriate. X-Legal-Confidentiality: This e-mail message is confidential and for use by the addressee only. If the message is received by anyone other than the addressee, please return the message to the sender by replying to it and then delete the message from your computer. Internet e-mails are not necessarily secure. Cloudsoft Corporation Limited does not accept responsibility for changes made to this message after it was sent. X-Legal-Company-Info: Cloudsoft Corporation Limited. Registered in Scotland. Number: SC349230. Registered Office: 13 Dryden Place, Edinburgh, EH9 1RP. archived-at: Tue, 07 Jun 2016 09:50:23 -0000 --047d7b5d441e8c03060534ad1d98 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable +1 On 7 June 2016 at 10:40, Svetoslav Neykov < svetoslav.neykov@cloudsoftcorp.com> wrote: > +1 > > Also agree having an environment will simplify writing the tests. > > Svet. > > > > On 7.06.2016 =D0=B3., at 12:37, Aled Sage wrote: > > > > Hi all, > > > > I suggest we rename the entity SimpleShellCommandTest [1] to > TestSshCommand. This would make it more consistent with the naming of > things like ShellFeed [2] and SshFeed [3]: "shell" means executing a > command on the local brooklyn server, whereas "ssh" means executing a > command on the given SshMachineLocation. Also, having the prefix "Test" i= s > more consistent with TestSensor, TestEffector, TestHttpCall, etc. > > > > I'll also add TestSshCommand.SHELL_ENVIRONMENT config key (to follow th= e > naming convention of VanillaSoftwareProcess.SHELL_ENVIRONMENT). > > > > Obviously we'd deprecate the old SimpleShellCommandTest, rather than > deleting it. > > > > Thoughts? > > > > Aled > > > > [1] http://brooklyn.apache.org/v/latest/yaml/test/index.html > > [2] > https://github.com/apache/brooklyn-server/blob/master/core/src/main/java/= org/apache/brooklyn/feed/shell/ShellFeed.java > > [3] http://brooklyn.apache.org/v/latest/java/feeds.html > > > > > > --047d7b5d441e8c03060534ad1d98--