Mailing-List: contact dev-help@brooklyn.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.apache.org
From: neykov <git@git.apache.org>
To: dev@brooklyn.apache.org
Reply-To: dev@brooklyn.apache.org
References: <git-pr-204-brooklyn-server@git.apache.org>
In-Reply-To: <git-pr-204-brooklyn-server@git.apache.org>
Subject: [GitHub] brooklyn-server issue #204: Move machine metrics to SoftwareProcess entity
Content-Type: text/plain
Message-Id: <20160620105654.14807DFC6F@git1-us-west.apache.org>
Date: Mon, 20 Jun 2016 10:56:54 +0000 (UTC)
archived-at: Mon, 20 Jun 2016 10:56:56 -0000

Github user neykov commented on the issue:

    https://github.com/apache/brooklyn-server/pull/204
  
    Will merge after moving enricher creation to `init` method.
    
    Stopping feeds in the stop effector feels like the right thing to do. This is the practice we follow in connect/disconnectSensors and having this done out of the box will simplify entity implementations. Still think feeds need some more attention in future PRs, especially around creation. Currently we create the feeds even if it's already added to the entity (and try to handle duplicates gracefully). Rebind will start the feeds without taking into consideration the entity state. Overall feels like feed workflow needs cleanup.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---