Mailing-List: contact dev-help@brooklyn.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.apache.org
From: aledsage <git@git.apache.org>
To: dev@brooklyn.apache.org
Reply-To: dev@brooklyn.apache.org
References: <git-pr-185-brooklyn-server@git.apache.org>
In-Reply-To: <git-pr-185-brooklyn-server@git.apache.org>
Subject: [GitHub] brooklyn-server pull request #185: Fix/effectors
Content-Type: text/plain
Message-Id: <20160607202918.37FFCDFB93@git1-us-west.apache.org>
Date: Tue,  7 Jun 2016 20:29:18 +0000 (UTC)
archived-at: Tue, 07 Jun 2016 20:29:20 -0000

Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/185#discussion_r66146520
  
    --- Diff: rest/rest-resources/src/main/java/org/apache/brooklyn/rest/transform/EffectorTransformer.java ---
    @@ -83,7 +84,8 @@ public static EffectorSummary effectorSummaryForCatalog(Effector<?> effector) {
                     .context(entity).timeout(ValueResolver.REAL_QUICK_WAIT).getMaybe();
                 return new ParameterSummary(parameterType.getName(), parameterType.getParameterClassName(), 
                     parameterType.getDescription(), 
    -                WebResourceUtils.getValueForDisplay(defaultValue.orNull(), true, false));
    +                WebResourceUtils.getValueForDisplay(defaultValue.orNull(), true, false),
    +                Sanitizer.IS_SECRET_PREDICATE.apply(parameterType.getName()));
    --- End diff --
    
    It looks like you added `parameterType.isSensitive`, but then don't use it here (and instead rely on `Sanitizer`). As I said in earlier comment, I think that's fine - in fact probably best to delete `isSensitive` if we're not going to use it everywhere.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---