brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <>
Subject [GitHub] brooklyn-server pull request #214: BROOKLYN-305: handle invalid xml chars in...
Date Wed, 22 Jun 2016 15:48:58 GMT
GitHub user aledsage opened a pull request:

    BROOKLYN-305: handle invalid xml chars in attribute vals

    I'm not convinced by this approach (calling a special method `XmlUtil.xpathHandlingIllegalChars()`,
which retries the xpath having escaped the illegal characters). It works well enough for us
because we are just making very basic use of xpath - it is primarily to just extact the entity
id from the xml file, before we try to fully deserialize it.

You can merge this pull request into a Git repository by running:

    $ git pull fix/xml-deserialize-illegal-chars

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #214
commit e15697f42eb103fb393ab391f53bcd1d7ebd4d38
Author: Aled Sage <>
Date:   2016-06-22T12:24:01Z

    Improve/test performance of XmlUtil.xpath

commit 7981326612d20a0d6bd9b7d972620f5e2e0b4fc3
Author: Aled Sage <>
Date:   2016-06-22T12:24:30Z

    Adds XmlSerializerTest

commit 17d496a9d73f2079349ba01cc8f296fa303efc40
Author: Aled Sage <>
Date:   2016-06-22T14:09:02Z

    BROOKLYN-305: Handle invalid xml chars in attribute vals


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message