brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #192: Adds OnSubnetNetworkEnricher
Date Thu, 09 Jun 2016 15:57:34 GMT
GitHub user aledsage opened a pull request:

    https://github.com/apache/brooklyn-server/pull/192

    Adds OnSubnetNetworkEnricher

    Some entities publish their endpoint using the public hostname (e.g. `MySqlNode` publishes
`datastore.url` using the sensor `host.name`). If trying to connect to it from within the
same subnet, this can fail if the public ip/hostname is not accessible.
    
    This topic is covered in the "Working with Multiple Networks" proposal (see dev@brooklyn
email thread). That suggests we should use the subnet address in things like the datastore.url.
That will likely break things for some of our users. But while we discuss/finalise that proposal...
    
    This enricher allows one to publish another sensor that definitely uses the subnet address.
It will publish the sensor as things like `datastore.url.mapping.subnet`.
    
    This is really a temporary solution (hence marking this as `@Beta`).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aledsage/brooklyn-server OnSubnetNetworkEnricher

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/192.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #192
    
----
commit 1660790c9c98b9993631f9107dd1c10c570de420
Author: Aled Sage <aled.sage@gmail.com>
Date:   2016-06-09T15:49:48Z

    Adds OnSubnetNetworkEnricher

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message