brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-server issue #219: Added identity method to DSL
Date Thu, 23 Jun 2016 22:25:58 GMT
Github user aledsage commented on the issue:

    https://github.com/apache/brooklyn-server/pull/219
  
    @grkvlt the code looks good.
    
    However, I'm unsure of the name "identity". We already have "id" in yaml, which means
something entirely different (i.e. it is the user-supplied identifier for referring to other
entities within yaml). I'd worry that "identity" will make people think that it will return
the id.
    
    Also, the pedant in me thinks that the internal id is an *identifier* rather than the
identity.
    
    Howe about `internalId()` instead?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message