brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From duncangrant <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #214: BROOKLYN-305: handle invalid xml chars in...
Date Wed, 22 Jun 2016 20:59:19 GMT
Github user duncangrant commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/214#discussion_r68134027
  
    --- Diff: core/src/test/java/org/apache/brooklyn/util/core/xstream/XmlUtilTest.java ---
    @@ -20,15 +20,65 @@
     
     import static org.testng.Assert.assertEquals;
     
    -import org.apache.brooklyn.util.core.xstream.XmlUtil;
    +import org.apache.brooklyn.util.core.xstream.XmlUtil.Escaper;
     import org.testng.annotations.Test;
     
    +import com.google.common.base.Optional;
    +
     
     public class XmlUtilTest {
     
         @Test
         public void testXpath() throws Exception {
             String xml = "<a><b>myb</b></a>";
    -        assertEquals(XmlUtil.xpath(xml, "/a/b[text()]"), "myb");
    +        for (int i = 0; i < 2; i++) {
    --- End diff --
    
    Why twice?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message