brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Graeme-Miller <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #204: Move machine metrics to SoftwareProcess e...
Date Tue, 21 Jun 2016 13:03:14 GMT
Github user Graeme-Miller commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/204#discussion_r67863025
  
    --- Diff: software/base/src/main/java/org/apache/brooklyn/entity/software/base/lifecycle/MachineLifecycleEffectorTasks.java
---
    @@ -709,9 +710,11 @@ protected void doStop(ConfigBag parameters, Callable<StopMachineDetails<Integer>
             DynamicTasks.queue("pre-stop", new PreStopCustomTask());
     
             Maybe<MachineLocation> machine = Machines.findUniqueMachineLocation(entity().getLocations());
    -        Task<String> stoppingProcess = null;
    +        Task<List<?>> stoppingProcess = null;
             if (canStop(stopProcessMode, entity())) {
    -            stoppingProcess = DynamicTasks.queue("stopping (process)", new StopProcessesAtMachineTask());
    +            stoppingProcess = Tasks.parallel(
    --- End diff --
    
    Aled and I debugged the hanging test today and narrowed it down to this line. The stoppingProcess
task is created, but never started.
    
    The following code can be used instead:
    `
    stoppingProcess = Tasks.parallel(
                        Tasks.<String>builder().displayName("stopping (process)").body(new
StopProcessesAtMachineTask()).build(),
                        Tasks.<String>builder().displayName("stopping (feeds)").body(new
StopFeedsAtMachineTask()).build());
                DynamicTasks.queue(stoppingProcess);
    `


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message