brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #208: Serialize complex objects as JSON in shel...
Date Tue, 21 Jun 2016 10:12:43 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/208#discussion_r67842336
  
    --- Diff: software/base/src/main/java/org/apache/brooklyn/entity/software/base/ShellEnvironmentSerializer.java
---
    @@ -0,0 +1,51 @@
    +/*
    + * Copyright 2016 The Apache Software Foundation.
    + *
    + * Licensed under the Apache License, Version 2.0 (the "License");
    + * you may not use this file except in compliance with the License.
    + * You may obtain a copy of the License at
    + *
    + *      http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.brooklyn.entity.software.base;
    +
    +import org.apache.brooklyn.api.mgmt.ManagementContext;
    +import org.apache.brooklyn.util.core.json.BrooklynObjectsJsonMapper;
    +import org.apache.brooklyn.util.exceptions.Exceptions;
    +
    +import com.fasterxml.jackson.core.JsonProcessingException;
    +import com.fasterxml.jackson.databind.ObjectMapper;
    +
    +public class ShellEnvironmentSerializer {
    +    private ObjectMapper mapper;
    +    
    +    public ShellEnvironmentSerializer(ManagementContext mgmt) {
    +        mapper = BrooklynObjectsJsonMapper.newMapper(mgmt);
    +    }
    +
    +    public String serialize(Object value) {
    +        if (value == null) return null;
    +        if (value instanceof String) return (String)value;
    +        try {
    +            String str = mapper.writeValueAsString(value);
    +            // Avoid dealing with unquoting and unescaping the serialized result is a
string
    +            if (isString(str)) {
    --- End diff --
    
    It refers to the json value within the string. You are right, I think `isJsonString` best
matches the intent.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message