brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Graeme-Miller <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #204: Move machine metrics to SoftwareProcess e...
Date Thu, 16 Jun 2016 12:55:55 GMT
Github user Graeme-Miller commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/204#discussion_r67338633
  
    --- Diff: software/base/src/main/java/org/apache/brooklyn/entity/software/base/SoftwareProcessImpl.java
---
    @@ -85,15 +81,20 @@
      * It exposes sensors for service state (Lifecycle) and status (String), and for host
info, log file location.
      */
     public abstract class SoftwareProcessImpl extends AbstractEntity implements SoftwareProcess,
DriverDependentEntity {
    -    private static final Logger log = LoggerFactory.getLogger(SoftwareProcessImpl.class);
    -    
    +
    +    private static final Logger LOG = LoggerFactory.getLogger(SoftwareProcessImpl.class);
    +
    +    static {
    +        MachineAttributes.init();
    --- End diff --
    
    do we need to call init, if we are already calling it in AddMachineMetrics?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message