brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #204: Move machine metrics to SoftwareProcess e...
Date Thu, 16 Jun 2016 08:28:11 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/204#discussion_r67305518
  
    --- Diff: software/base/src/main/java/org/apache/brooklyn/entity/software/base/SoftwareProcessImpl.java
---
    @@ -373,6 +468,8 @@ protected void postRestart() {
          */
         protected void disconnectSensors() {
             connectedSensors = false;
    +        boolean retrieveMachineMetrics = config().get(RETRIEVE_MACHINE_METRICS);
    +        if (retrieveMachineMetrics) disconnectMachineSensors();
    --- End diff --
    
    (minor) I'd always call that and depend on the null check inside.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message