brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-library issue #34: Fix sed command that update the MySQL configurat...
Date Mon, 13 Jun 2016 08:52:52 GMT
Github user aledsage commented on the issue:

    https://github.com/apache/brooklyn-library/pull/34
  
    @tbouron what do you think of @neykov 's comments?
    
    What problem do you hit with the old code, and on what environment(s)?
    
    I believe the old code is trying to support OSX and Linux (but probably doesn't manage
to). That's tricky because `sed -i` behaves differently (see discussion in http://stackoverflow.com/questions/2320564/variations-of-sed-between-osx-and-gnu-linux).
    
    Can we add an integration/live test for this?
    
    As an aside: we can almost test this in isolation as an integration test, because `ChangePasswordEffectorBody`
is defined separately from the `MySqlNode`! Except for the fact that the impl does `((MySqlNodeImpl)entity()).getDriver()`.
If it wasn't for that, you could create a `VanillaSoftwareProcess`, wire in that effector,
create a `mymysql.cnf` file in its run dir, set the attribute `MySqlNode.PASSWORD` on your
test entity, and then call the effector. But probably not worth trying to refactor to make
that possible.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message