brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #180: prevent OOME on big streams and better lo...
Date Thu, 09 Jun 2016 23:19:20 GMT
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/180#discussion_r66538902
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/BrooklynTaskTags.java ---
    @@ -190,9 +190,16 @@ protected WrappedStream(String streamType, ByteArrayOutputStream
stream) {
             public Integer getStreamSize() {
                 return streamSize.get();
             }
    -        // there is a stream api so don't return everything unless explicitly requested!
    +        // there is a stream call on Activity REST api which accesses streamContent.get()
directly;
    +        // so when serializing the tag, abbreviate things
             @JsonProperty("streamContents")
             public String getStreamContentsAbbreviated() {
    +            // TODO would be nice to just get the first 80 chars but that's a refactoring
    +            // which might affect persistence.  if stream is very large (100MB+) then
we sometimes
    --- End diff --
    
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message