brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <>
Subject [GitHub] brooklyn-server pull request #185: Fix/effectors
Date Tue, 07 Jun 2016 20:29:18 GMT
Github user aledsage commented on a diff in the pull request:
    --- Diff: rest/rest-resources/src/main/java/org/apache/brooklyn/rest/transform/
    @@ -83,7 +84,8 @@ public static EffectorSummary effectorSummaryForCatalog(Effector<?>
effector) {
                 return new ParameterSummary(parameterType.getName(), parameterType.getParameterClassName(),

    -                WebResourceUtils.getValueForDisplay(defaultValue.orNull(), true, false));
    +                WebResourceUtils.getValueForDisplay(defaultValue.orNull(), true, false),
    +                Sanitizer.IS_SECRET_PREDICATE.apply(parameterType.getName()));
    --- End diff --
    It looks like you added `parameterType.isSensitive`, but then don't use it here (and instead
rely on `Sanitizer`). As I said in earlier comment, I think that's fine - in fact probably
best to delete `isSensitive` if we're not going to use it everywhere.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message