brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #185: Fix/effectors
Date Tue, 07 Jun 2016 20:27:18 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/185#discussion_r66146158
  
    --- Diff: api/src/main/java/org/apache/brooklyn/api/effector/ParameterType.java ---
    @@ -45,4 +47,6 @@
          * @return The default value for this parameter, if not supplied during an effector
call.
          */
         public T getDefaultValue();
    +
    +    public boolean isSensitive();
    --- End diff --
    
    I really worry about adding this - do we actually respect it properly? In many places
we just have a `ConfigBag` without the `ParameterType` definition, so we can only infer from
the name whether it looks like a password/credential.
    
    If we include `isSensitive` here, then it will set a false expectation of what we'll do
with it.
    
    Should we just rely on `sanitize`, and get rid of `isSensitive`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message