brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sjcorbett <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #185: Fix/effectors
Date Tue, 07 Jun 2016 17:32:56 GMT
Github user sjcorbett commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/185#discussion_r66116186
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/effector/BasicParameterType.java
---
    @@ -44,6 +45,7 @@ public BasicParameterType(Map<?, ?> arguments) {
             if (arguments.containsKey("type")) type = (Class<T>) arguments.get("type");
             if (arguments.containsKey("description")) description = (String) arguments.get("description");
             if (arguments.containsKey("defaultValue")) defaultValue = (T) arguments.get("defaultValue");
    +        if (arguments.containsKey("sensitive")) defaultValue = (T) arguments.get("sensitive");
    --- End diff --
    
    Is it possible for the value in the map to be null? If yes then use `Boolean.TRUE.equals(args.get(..))`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message