brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] brooklyn-library pull request #33: Allow creating roles for PostgreSQL
Date Tue, 07 Jun 2016 14:08:16 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-library/pull/33#discussion_r66077096
  
    --- Diff: qa/src/test/resources/java-web-app-and-db-with-function.yaml ---
    @@ -21,12 +21,13 @@ location: localhost
     services:
     - type: org.apache.brooklyn.entity.webapp.ControlledDynamicWebAppCluster
       name: My Web
    -  wars.root: http://repo1.maven.org/maven2/org/apache/brooklyn/example/brooklyn-example-hello-world-sql-webapp/0.9.0/brooklyn-example-hello-world-sql-webapp-0.9.0.war
    -  http.port: 9280+
    -  proxy.http.port: 9210+
    -  java.sysprops: 
    -    brooklyn.example.db.url: $brooklyn:formatString("jdbc:%s%s?user=%s&password=%s",
    -       component("db").attributeWhenReady("datastore.url"), "visitors", "brooklyn", "br00k11n")
    +  brooklyn.config:
    --- End diff --
    
    I'm surprised this is needed, but it's most probably a good thing to include the `brooklyn.config`,
so happy to merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message