brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nakomis <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #150: Ability to perform installation on a Wind...
Date Mon, 06 Jun 2016 14:35:35 GMT
Github user nakomis commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/150#discussion_r65900734
  
    --- Diff: software/base/src/main/java/org/apache/brooklyn/entity/software/base/VanillaWindowsProcessWinRmDriver.java
---
    @@ -49,15 +50,28 @@ public void start() {
     
         @Override
         public void install() {
    +        String hostname = null;
    --- End diff --
    
    At some point in the future, this should probably be refactored to get the name of the
machine in `WinRmMachineLocation` and set it as the hostname sensor. Please add a TODO note
here suggesting the same 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message