brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From grkvlt <>
Subject [GitHub] brooklyn-server pull request #127: Add configuration option to SSH sensor to...
Date Mon, 06 Jun 2016 14:23:53 GMT
Github user grkvlt commented on a diff in the pull request:
    --- Diff: core/src/main/java/org/apache/brooklyn/feed/ssh/ ---
    @@ -267,13 +261,13 @@ public SshPollValue call() throws Exception {
         private SshPollValue exec(String command, Map<String,String> env) throws IOException
             SshMachineLocation machine = getMachine();
    -        Boolean execAsCommand = getConfig(EXEC_AS_COMMAND);
    +        Boolean execAsCommand = config().get(EXEC_AS_COMMAND);
             if (log.isTraceEnabled()) log.trace("Ssh polling for {}, executing {} with env
{}", new Object[] {machine, command, env});
             ByteArrayOutputStream stdout = new ByteArrayOutputStream();
             ByteArrayOutputStream stderr = new ByteArrayOutputStream();
             int exitStatus;
    -        ConfigBag flags = ConfigBag.newInstance()
    +        ConfigBag flags = ConfigBag.newInstanceExtending(config().getBag())
    --- End diff --
    This change is because we are adding some extra config overrides, and it seemed to be
the correct method to use based on the JavaDoc.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message