brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #171: Use login port for ssh
Date Mon, 06 Jun 2016 12:40:21 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/171#discussion_r65882584
  
    --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java
---
    @@ -2896,7 +2896,7 @@ protected LoginCredentials waitForSshable(final ComputeService computeService,
f
             String user = (users.size() == 1) ? Iterables.getOnlyElement(users) : "{" + Joiner.on(",").join(users)
+ "}";
             String vmIp = hostAndPortOverride.isPresent() ? hostAndPortOverride.get().getHostText()
: getFirstReachableAddress(node, setup);
             if (vmIp==null) LOG.warn("Unable to extract IP for "+node+" ("+setup.getDescription()+"):
subsequent connection attempt will likely fail");
    -        int vmPort = hostAndPortOverride.isPresent() ? hostAndPortOverride.get().getPortOrDefault(22)
: 22;
    +        int vmPort = hostAndPortOverride.isPresent() ? hostAndPortOverride.get().getPortOrDefault(22)
: getLoginPortOrDefault(node, 22);
    --- End diff --
    
    Shouldn't `22` in `getPortOrDefault(22)` be replaced as well?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message