brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <>
Subject [GitHub] brooklyn-server pull request #173: BROOKLYN-286: merge config keys map value...
Date Thu, 02 Jun 2016 13:15:54 GMT
Github user aledsage commented on a diff in the pull request:
    --- Diff: utils/common/src/main/java/org/apache/brooklyn/config/
    @@ -20,31 +20,60 @@
    +import org.apache.brooklyn.util.text.Strings;
     public abstract class ConfigInheritance implements Serializable {
    -    public static final ConfigInheritance ALWAYS = new Always();
    +    public enum InheritanceMode {
    --- End diff --
    Agreed. If we went back in time to review the very first pull request, then I'd change
it to be simpler (rather than context-dependent behaviour). But now that we have the code,
let's keep it "just in case".

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message