brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] brooklyn-server pull request #173: BROOKLYN-286: merge config keys map value...
Date Thu, 02 Jun 2016 12:35:16 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/173#discussion_r65530673
  
    --- Diff: utils/common/src/main/java/org/apache/brooklyn/config/ConfigInheritance.java
---
    @@ -20,31 +20,60 @@
     
     import java.io.Serializable;
     
    +import org.apache.brooklyn.util.text.Strings;
    +
     import com.google.common.annotations.Beta;
     
     @SuppressWarnings("serial")
     public abstract class ConfigInheritance implements Serializable {
     
    -    public static final ConfigInheritance ALWAYS = new Always();
    +    public enum InheritanceMode {
    --- End diff --
    
    Agree they represent the same thing currently. But on the other hand `ConfigInheritance`
allows us to have context-dependent behaviour. We didn't need it so far, but doesn't hurt
leaving it "just in case".


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message