Mailing-List: contact dev-help@brooklyn.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.apache.org
From: aledsage <git@git.apache.org>
To: dev@brooklyn.apache.org
Reply-To: dev@brooklyn.apache.org
References: <git-pr-150-brooklyn-server@git.apache.org>
In-Reply-To: <git-pr-150-brooklyn-server@git.apache.org>
Subject: [GitHub] brooklyn-server pull request: Ability to suppress install command ...
Content-Type: text/plain
Message-Id: <20160524120805.C3AB2DFB14@git1-us-west.apache.org>
Date: Tue, 24 May 2016 12:08:05 +0000 (UTC)
archived-at: Tue, 24 May 2016 12:08:07 -0000

Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/150#discussion_r64378738
  
    --- Diff: software/base/src/main/java/org/apache/brooklyn/entity/software/base/AbstractSoftwareProcessWinRmDriver.java ---
    @@ -161,12 +161,16 @@ public WinRmMachineLocation getMachine() {
         }
     
         protected int executeCommandInTask(String command, String psCommand, String phase) {
    +        return executeCommandInTask(command, psCommand, phase, false);
    +    }
    +
    +    protected int executeCommandInTask(String command, String psCommand, String phase, boolean suppressFailures) {
             return newScript(phase)
                     .setCommand(command)
                     .setPsCommand(psCommand)
                     .failOnNonZeroResultCode()
                     .gatherOutput()
    -                .execute();
    +                .execute(suppressFailures);
    --- End diff --
    
    Why is `suppressFailures` special (i.e. passing it as a parameter to `execute()`, rather than calling `.suppressFailures(suppressFailures)` to configure the script before calling a no-arg `execute()`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---