Mailing-List: contact dev-help@brooklyn.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.apache.org
From: ahgittin <git@git.apache.org>
To: dev@brooklyn.apache.org
Reply-To: dev@brooklyn.apache.org
References: <git-pr-136-brooklyn-server@git.apache.org>
In-Reply-To: <git-pr-136-brooklyn-server@git.apache.org>
Subject: [GitHub] brooklyn-server pull request: Fix/required open ports
Content-Type: text/plain
Message-Id: <20160513085633.CFB75DFB73@git1-us-west.apache.org>
Date: Fri, 13 May 2016 08:56:33 +0000 (UTC)
archived-at: Fri, 13 May 2016 08:56:35 -0000

Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/136#discussion_r63151939
  
    --- Diff: software/base/src/main/java/org/apache/brooklyn/entity/software/base/InboundPortsUtils.java ---
    @@ -77,12 +82,17 @@
                 Set<ConfigKey<?>> configKeys = Sets.newHashSet(extraConfigKeys);
                 configKeys.addAll(entity.getEntityType().getConfigKeys());
                 // Also add dynamically added config keys
    -            configKeys.addAll(((EntityInternal)entity).config().getBag().getAllConfigAsConfigKeyMap().keySet());
    +            Map<ConfigKey<?>, ?> configuredConfigKeys = ImmutableMap.copyOf(((EntityInternal) entity).config().getBag().getAllConfigAsConfigKeyMap());
    +            configKeys.addAll(configuredConfigKeys.keySet());
    --- End diff --
    
    why create the intermediate `Immutable`?  is there a risk if a value in the may is null that it will now throw NPE?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---